Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector to v0.30.1 #9944

Merged
merged 1 commit into from
May 11, 2022
Merged

Update github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector to v0.30.1 #9944

merged 1 commit into from
May 11, 2022
+79 −48

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented May 10, 2022 •
edited
Loading

Description:

Update the gcp collector dependency. It includes one additional commit on top of v0.30.1, which removes the dependency on opencensus translation: GoogleCloudPlatform/opentelemetry-operations-go#390.

Forked from #9920, since it requires some additional changes to keep tests working.

@dashpole dashpole requested a review from a team May 10, 2022 20:11
@dashpole dashpole requested review from jsuereth and punya as code owners May 10, 2022 20:11
@dashpole dashpole requested a review from dmitryax May 10, 2022 20:11
@dashpole dashpole added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 10, 2022
@dashpole
Copy link
Contributor Author

cd @codeboten @bogdandrutu

codeboten
codeboten approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dashpole!

@bogdandrutu
Copy link
Member

@dashpole please rebase

@dmitryax
Copy link
Member

@dashpole I see that googlecloudexporter has github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector dependency which uses github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/opencensus as another dependency. I'm curious if this interdependency is planned to be resolved? Looks like this is the only place where gcp depends on contrib https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/main/exporter/collector/traces_test.go#L270

@dashpole
Copy link
Contributor Author

Thanks for reminding me. I'll try and resolve that this week

@dashpole dashpole mentioned this pull request May 11, 2022
Merged
@dashpole
Copy link
Contributor Author

This PR now includes the commit that removes the opencensus translation dependency. PTAL!

@bogdandrutu bogdandrutu merged commit d1a8818 into open-telemetry:main May 11, 2022
@dashpole dashpole deleted the update_gcp branch May 12, 2022 13:39
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
@igorpeshansky igorpeshansky mentioned this pull request May 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@codeboten codeboten codeboten approved these changes

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@punya punya Awaiting requested review from punya

Assignees

@djaglowski djaglowski

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dashpole @bogdandrutu @dmitryax @codeboten @djaglowski